PR to close #29 missing can isotp wait tx done flag to trigger a timeout #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, an UDS client run on the Linux ISOTP kernel module was not able to recognize a timeout error of a Flow Control frame not arriving in time after a multi-frame request. To fix this, the flag CAN_ISOTP_WAIT_TX_DONE is set on the socket. Otherwise writing the bytes of the SEND buffer to the ISOTP socket would incorrectly return the expected SEND buffer size, creating further problems like e.g. a timeout waiting on the response of the "sent" request, since it was not really sent so the UDS server is not sending a response.
…n a client ISOTP socket with no responding server With this test it can be assured that by having set the CAN_ISOTP_WAIT_TX_DONE flag on an ISOTP socket a communication error will be raised after trying to send a multi-frame request to an UDS server that will not send a FC frame within 1s.
muehlke
commented
Jun 14, 2024
| } | ||
|
|
||
| // killing server so that no response is sent to client | ||
| ENV_TpFree(srv); |
There was a problem hiding this comment.
I added ENV_TpFree(srv); because for the test it is necessary that no server responds to the request so that we can get the desired timeout on the ISOTP socket. Because of the timeout error, the value of ret is <0, which was not the case before the flag was set on the socket.
|
@driftregion if |
|
Thanks you for your contribution @muehlke |
muehlke
deleted the
29-missing-can-isotp-wait-tx-done-flag-to-trigger-a-timeout
branch
|
You're welcome, keep up the good work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29